Skip to content

m4/nut_check_python.m4: allow overriding of PYTHON{2,3}_SITE_PACKAGES#2147

Merged
jimklimov merged 1 commit into
networkupstools:masterfrom
ffontaine:master
Nov 5, 2023
Merged

m4/nut_check_python.m4: allow overriding of PYTHON{2,3}_SITE_PACKAGES#2147
jimklimov merged 1 commit into
networkupstools:masterfrom
ffontaine:master

Conversation

@ffontaine
Copy link
Copy Markdown
Contributor

Allow the end-user to override PYTHON{2,3}_SITE_PACKAGES as this can be useful when cross-compiling

Allow the end-user to override PYTHON{2,3}_SITE_PACKAGES as this can be
useful when cross-compiling

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@jimklimov
Copy link
Copy Markdown
Member

Thanks, seems reasonable :)

Let's see how CI likes it. Eventually, it would be great to also get a PR for updates to docs/config-prereqs.txt and/or docs/ci-farm-lxc-setup.txt about setting up a worker for cross-build scenarios in the NUT CI farm.

So far there are very occasional (manually triggered) runs in whole containers running under qemu for this or that platform - which is prohibitively slow to be done regularly, and sometimes blows up with unimplemented CPU instructions etc.

If there could be some mix, e.g. using a native (amd64) gcc or clang binary with appropriate resource file trees to produce ARM etc. binaries, and only use qemu-static to actually run them for make check check-NIT tests, that would probably be a workable balance. For best results, we
may also have to teach our AX_RUN_OR_LINK_IFELSE m4 macro about some caller-defined option that this cross-builder can also run the binaries it has just built (which is not the default case).

@jimklimov jimklimov added cross-builds portability We want NUT to build and run everywhere possible impacts-release-2.8.1 Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks) labels Nov 5, 2023
@jimklimov jimklimov added this to the 2.8.2 milestone Nov 5, 2023
@jimklimov jimklimov added CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) python labels Nov 5, 2023
@jimklimov jimklimov merged commit c3ad3d3 into networkupstools:master Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) cross-builds impacts-release-2.8.1 Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks) portability We want NUT to build and run everywhere possible python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants