Refactor void* casting to specific types, indentations and other noisy stuff#3297
Merged
jimklimov merged 16 commits intonetworkupstools:masterfrom Feb 4, 2026
Merged
Conversation
jimklimov
added
CI
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This fixes the build fail triggered on CI farm, and some more that trigger on the more recent version 21 of clang. Signed-off-by: Tim Niemueller <tim@niemueller.de> Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
On the used clang version implicit conversion triggers a warning, the `-Werror` makes those errors. I have used Gemini for some of these, but quota ran out after half an hour and ~120 invocations so I completed the rest manually. Signed-off-by: Tim Niemueller <tim@niemueller.de> Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Kudos to Tim Niemueller, Gemini, and clang-21 extended warnings. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…apping table entry types etc. via enum values [networkupstools#3293] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ture and method arguments Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…orkupstools#3293] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ULLness at the beginning of main() [networkupstools#3293] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…the iteration variable name Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ng of xmalloc() [networkupstools#3293] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Bonus question: what could Gemini mean by "FTS"?.. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…mge_model_names[] [networkupstools#3293] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… *)1` also in comparisons Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…IPMI on this host" to report the message Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
force-pushed
the
issue-3293-refactoring
branch
from
0ef9d1a to
838c162
Compare
|
✅ Build nut 2.8.4.4158-master completed (commit 638d154a01 by @jimklimov) |
jimklimov
force-pushed
the
issue-3293-refactoring
branch
4 times, most recently
from
dd99e43 to
838c162
Compare
|
✅ Build nut 2.8.4.4161-master completed (commit 454bcccad1 by @jimklimov) |
jimklimov
added
C-str
jimklimov
added
the
AI
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 8, 2026
…/generic_gpio_utest.c: fix more casting from xcalloc() et al [networkupstools#3297] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 8, 2026
… et al [networkupstools#3297] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Feb 8, 2026
…t assign plain number to enum variables [networkupstools#3297] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by changes in PR #3293 by @timn that were needed to build the NUT code base with the new and ever more picky
clang-21compiler version, and test that PR's own merits.Overall this was a lot of noise for hopefully idempotent code base change, which obscured modifications related to that PR, so posting as a separate big refactoring wad (and adding some indentation fixes etc. as mangled by edits of the original commits.