Enhance libnutclient (C++) with SSL (NUT STARTTLS) support and test it#3353
Merged
jimklimov merged 39 commits intonetworkupstools:masterfrom Mar 21, 2026
Merged
Enhance libnutclient (C++) with SSL (NUT STARTTLS) support and test it#3353jimklimov merged 39 commits intonetworkupstools:masterfrom
jimklimov merged 39 commits intonetworkupstools:masterfrom
Conversation
b753ab2 to
9ae929f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7329d62 to
d0cb3f2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Some troubles remain with certificate setup:
|
This comment was marked as outdated.
This comment was marked as outdated.
…etworkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… (which can throw exceptions) [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ent::getSslCaps() [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…() [networkupstools#1599, networkupstools#1600, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…Y_PASS [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…workupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ons for a while but in vain [networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rate config/autocall methods for OpenSSL and NSS [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ed empty [networkupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
, networkupstools#1711] Inspired by termux/termux-packages#23578 and https://github.com/termux/termux-packages/pulls/23579 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…workupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…orkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…T_PASS in NSS; there is a database prefix however [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… options for (Open)SSL [networkupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…y to future-proof passing OpenSSL or NSS (or other backend) options to TcpClient::setSSLConfig() and constructor [networkupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…()/setSSLConfig_OpenSSL() backend-specific methods (APIs may evolve, SSLConfig classes should be more flexible) [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
networkupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…tools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…td::string& [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…har* (even if nullptr) [networkupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ay be toxic in this context [networkupstools#1599, networkupstools#3353] Warning Incorrect allocation-error handling This allocation cannot return null. This check is unnecessary. cpp/incorrect-allocation-error-handling: Different overloads of the new operator handle allocation failures in different ways. If new T fails for some type T, it throws a std::bad_alloc exception, but new(std::nothrow) T returns a null pointer. If the programmer does not use the corresponding method of error handling, allocation failure may go unhandled and could cause the program to behave in unexpected ways. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Mar 21, 2026
…#3353] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Mar 22, 2026
…#3353] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses at least parts of:
Adds various improvements to the NIT script along the way.
AI DISCLAIMER: Prepared with contributions from IntelliJ Junie, mostly to speed up repetitive coding patterns like getters/setters.