Keep VoteRank ability nonnegative (issue #3826)#3970
Merged
dschult merged 1 commit intonetworkx:masterfrom May 28, 2020
Merged
Conversation
dschult
changed the title
dschult
changed the title
kiryph
pushed a commit
to kiryph/networkx
that referenced
this pull request
Jul 21, 2020
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #3826, in the current implementation of VoteRank, the voting ability of a few nodes could become negative.
This was because step 4 of the reference paper was wrongly implemented. Step 4 states that the voting ability is updated only if the new value doesn't become negative. This is fixed in the pull request.