Remove structuralholes.py from needs_(num|sci)py#8088
Merged
Conversation
dschult
approved these changes
Jun 2, 2025
amcandio
pushed a commit
to amcandio/networkx
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the PR that recently updated structuralholes.py to understand #8087, I saw it added that file to the
needs_numpyandneeds_scipylists in conftest.py. This excludes them from being tested when scipy (or numpy) is not available (strictly, this isn't the case, as thenodesargument is also considered in theif—but afaik there's no good reason to exclude these from the tests). However, the functions with a scipy implementation explicitly wrapimport scipyin atry ... exceptusing scipy where possible. As a result, the vanilla implementation does not get tested properly: when running thedefaulttests (with scipy), the scipy implementation gets tested, and when runningdefault-without-scipy, the file gets skipped.