Handling empty graph edge-case for betweenness_centrality and edge_betweenness_centrality
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschult
reviewed
Mar 25, 2025
| for chunk in node_chunks | ||
| ) | ||
|
|
||
| if not bt_cs: |
Member
There was a problem hiding this comment.
I think we should probably put this right after we update G. For this one, that is line 43. We avoid extra work by checking len(G) == 0 and returning {} in that case. Thoughts?
Schefflera-Arboricola
changed the title
betweenness_centrality and edge_betweenness_centrality
Contributor
Author
|
I'm a bit unsure about how these checks are failing since the only change I made was moving the empty graph check. Could you help me understand if I might be missing something? |
Schefflera-Arboricola
approved these changes
Mar 26, 2025
Member
Schefflera-Arboricola
left a comment
Schefflera-Arboricola
left a comment
There was a problem hiding this comment.
Thanks @akshitasure12 and @dschult !
The failing CI tests are due to the recent changes in PR networkx/networkx#7908 and could be handled in a separate PR. refer Issue #101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #99 by adding a condition to return an empty dictionary
{}for empty graphs in the following functions:betweenness_centralityedge_betweenness_centralityI am planning to implement similar checks for other functions as well.
Let me know if I should tweak it any further!