Skip to content

Training may29#1034

Merged
hilram7 merged 14 commits into
devfrom
training-may29
May 29, 2026
Merged

Training may29#1034
hilram7 merged 14 commits into
devfrom
training-may29

Conversation

@robin-stefani
Copy link
Copy Markdown
Collaborator

@robin-stefani robin-stefani commented May 29, 2026

NIM updates: new 3722 course and new v7.0 CTW.
NAA26 updates: new 5020 course and new CTW
N1S updates: updates to 1600, 3600.6, and 5600 courses.
NPC update: new 2680 course.

Closes #1035

@github-actions
Copy link
Copy Markdown
Contributor

Auto-Fix Summary

2 issues fixed, 0 skipped across 11 files

Category Fixes
Repetition (rewrite) 1
Dale: passive-voice 1

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions
Copy link
Copy Markdown
Contributor

Auto-Fix Summary

0 issues fixed, 0 skipped across 11 files

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions
Copy link
Copy Markdown
Contributor

Auto-Fix Summary

0 issues fixed, 2 skipped across 11 files

Skipped (needs manual review) Reason

| docs/partner/implementation/identity-manager.md:15 — Dale: wordiness | Sentence 'When the final courses are available to grant certification, this learning path will include them' is slightly long but tightening risks changing meaning about which courses will grant certification. |
| docs/partner/implementation/identity-manager.md:21 — Dale: undefined-acronyms | IGA appears in a bulleted course-title list (heading-style), not body prose; define-on-first-use applies to body prose only per rule guidance. |

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions
Copy link
Copy Markdown
Contributor

Auto-Fix Summary

0 issues fixed, 0 skipped across 11 files

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions
Copy link
Copy Markdown
Contributor

Code Review

No correctness issues found. This PR is purely content/training-path updates — no changes to products.js, docusaurus.config.js, sidebars, scripts, or workflows.

Verified:

  • File rename 1secure-core.md1secure.md is fully propagated: all 8 references in partner/presales/index.md updated; no stale references remain anywhere.
  • New MDX component exports (N1SDemo, NAA26Demo, NIMConnectors, NPCConcepts) are added to their respective index.js files and all consumers import them correctly.
  • Removed import N1SDemoCore has no remaining references.
  • Removed import NAMAdditional from partner/presales/access-analyzer-26.md is safe — still exported and used by other partner pages (access-analyzer.md, implementation/access-analyzer-26.md, implementation/access-analyzer.md).
  • New source files (src/training/access-analyzer-26/5020.md, 1secure/5600.md, identity-manager/3722.md, pingcastle/2680.md) all exist and use valid MDX import syntax.
  • Sidebar position 1230 on the renamed 1secure.md is unchanged from the original file — no ordering conflicts.

Build risk: low. Docusaurus would catch any broken imports or links at build time (onBrokenLinks: 'throw'), and nothing here suggests it would.

@github-actions
Copy link
Copy Markdown
Contributor

Auto-Fix Summary

0 issues fixed, 0 skipped across 11 files

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions
Copy link
Copy Markdown
Contributor

Documentation PR Review

Editorial Review

docs/customer/training/learn-about/1secure.md

  • No issues found.

docs/customer/training/learn-about/pingcastle.md

  • No issues found.

docs/customer/training/product/1secure.md

  • No issues found.

docs/customer/training/product/identity-manager.md

  • No issues found.

docs/customer/training/product/pingcastle.md

  • Clarity — Line 15: The revised sentence still reads "In this learning path, you will learn how to use " while the sibling learn-about/pingcastle.md now uses the active, present-tense "This learning path introduces you to ." Since this line was already touched to fix the "course" → "courses" pluralization, consider also updating it for consistency with the active-voice change applied elsewhere in this PR. Suggested fix: "This learning path teaches you how to use . It contains the following courses:"

docs/partner/implementation/identity-manager.md

  • No issues found.

docs/partner/presales/1secure.md

  • No issues found.

docs/partner/presales/access-analyzer-26.md

  • Structure — Lines 14–16: The new structure is a significant improvement over the previous "watch these recordings" placeholder, and the course list, render order, and prose now match the pattern used by the other Presales pages. Confirm that other files in this folder that still reference Access Analyzer 26 (e.g., the index.md entries) line up with the new "Presales Engineer" framing. No fix needed if all links and labels already match.

docs/partner/presales/identity-manager.md

  • No issues found.

docs/partner/presales/index.md

  • No issues found. The rename from "1Secure Core Presales Engineer" to "1Secure Presales Engineer" is applied consistently across all category sections.

docs/partner/presales/pingcastle.md

  • No issues found. The new "2680 – Concepts & Architecture" entry and <NPCConcepts /> render are placed in the correct order relative to surrounding courses.

Summary

1 editorial suggestion across 11 files. The PR is mostly mechanical updates — revised estimated lengths, new courses added to learning paths, pluralization fixes, and the "1Secure Core" → "1Secure" rename. Changes are consistent and well-placed. Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@robin-stefani robin-stefani marked this pull request as ready for review May 29, 2026 18:10
@robin-stefani robin-stefani requested a review from a team as a code owner May 29, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin: PR review — Training may29 (PR #1034)

3 participants