Skip to content

fix: ensure doc-pr review posts as PR comment#455

Merged
jth-nw merged 1 commit intodevfrom
fix/doc-pr-posting
Mar 10, 2026
Merged

fix: ensure doc-pr review posts as PR comment#455
jth-nw merged 1 commit intodevfrom
fix/doc-pr-posting

Conversation

@jth-nw
Copy link
Collaborator

@jth-nw jth-nw commented Mar 10, 2026

Root cause: Claude completed all 3 review stages but never called gh pr comment — it returned the results as text output instead. Also, skill argument parsing was broken ($1 got the PR number instead of the file list).

Changes:

  • Pass REPO, PR_NUMBER, and FILES as env vars (DOC_PR_*) so the skill reads them reliably instead of depending on positional args
  • Add explicit "you MUST post" instructions in both the workflow prompt and the skill output section
  • Restructure skill output as two clear steps: write file, then post
  • Add fetch-depth: 1 to checkout for faster clones

Root cause: Claude completed all 3 review stages but never called
gh pr comment — it returned the results as text output instead.
Also, skill argument parsing was broken ($1 got the PR number
instead of the file list).

Changes:
- Pass REPO, PR_NUMBER, and FILES as env vars (DOC_PR_*) so the
  skill reads them reliably instead of depending on positional args
- Add explicit "you MUST post" instructions in both the workflow
  prompt and the skill output section
- Restructure skill output as two clear steps: write file, then post
- Add fetch-depth: 1 to checkout for faster clones

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jth-nw jth-nw merged commit 4045e8e into dev Mar 10, 2026
2 of 5 checks passed
@jth-nw jth-nw deleted the fix/doc-pr-posting branch March 16, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant