fix(workflow): check out PR head branch so fixes push to the PR#734
Merged
fix(workflow): check out PR head branch so fixes push to the PR#734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The workflow checked out the base branch (
dev) rather than the PR head branch. As a result, when the autofix script committed and pushed its changes, they went todevinstead of the PR branch — so renamed files never appeared in the PR diff.The bot comment was posted regardless of push success (the push step uses
continue-on-error: true), which is why the workflow appeared to work while the files weren't actually being renamed in the PR.Fix
reffrompull_request.base.reftopull_request.head.refso the bot commits land on the PR branch