fix: typo#332
Merged
Merged
Conversation
RichardHNetwrix
approved these changes
Mar 11, 2026
DXInfinity
added a commit
to DevExpress/pingcastle
that referenced
this pull request
May 20, 2026
commit d3d930d Author: RichardHNetwrix <richard.hanson@netwrix.com> Date: Thu May 14 16:37:12 2026 +0100 Pingcastle 3.5.1 Release (netwrix#350) commit d0f3425 Author: Sacha ATHIAS <126006948+sacha-athias-wmx@users.noreply.github.com> Date: Thu Apr 30 15:51:00 2026 +0200 feat(pingcastle): add json output feature (netwrix#343) * feat(pingcastle): add json output feature * fix(pingcastlecommon): apply review commentary * fix(pingcastle): Apply suggestion from @RichardHNetwrix Co-authored-by: RichardHNetwrix <richard.hanson@netwrix.com> Signed-off-by: Sacha ATHIAS <126006948+sacha-athias-wmx@users.noreply.github.com> * fix(json-export): honor XmlIgnore-only properties and XML element names - Use || instead of && so properties marked with either [XmlIgnore] or [IgnoreDataMember] are excluded from JSON output - Honor [XmlElement] and [XmlArray] ElementName so JSON field names match the XML output (e.g. CategoryAsString -> Category) --------- Signed-off-by: Sacha ATHIAS <126006948+sacha-athias-wmx@users.noreply.github.com> Co-authored-by: RichardHNetwrix <richard.hanson@netwrix.com> commit 9393a5f Author: compass-dexter <145257008+compass-dexter@users.noreply.github.com> Date: Wed Mar 11 12:40:38 2026 +0100 fix: typo (netwrix#332) commit c4052ef Author: compass-dexter <145257008+compass-dexter@users.noreply.github.com> Date: Tue Mar 10 14:38:07 2026 +0100 fix: typo (netwrix#330) commit f64d4ae Author: Yeonseok Jang <ystobiasjang@gmail.com> Date: Tue Mar 10 20:53:31 2026 +0900 fix: preserve AdminSDHolder delegations (netwrix#328) Made-with: Cursor commit d3e79dc Author: Yeonseok Jang <ystobiasjang@gmail.com> Date: Tue Mar 10 20:42:56 2026 +0900 Fix typo: buitinDomain -> builtinDomain in LDAP filters (netwrix#319) The Builtin container (objectCategory=builtinDomain) was never matched due to the typo, so its delegations were excluded from health check. commit 0e4dbd2 Author: Yeonseok Jang <ystobiasjang@gmail.com> Date: Tue Mar 10 20:42:16 2026 +0900 Exclude 1601-01-01 (password never set) from PasswordDistribution (netwrix#320) Accounts with pwdLastSet = 1601-01-01 (AD "never set") were counted in the password age distribution as ~5176 months old. Compare with DateTime.FromFileTime(0) (= 1601-01-01) and use WhenCreated as fallback so only real password ages are counted. commit 62237e8 Author: Christian Sandfeld <csandfeld@users.noreply.github.com> Date: Tue Mar 10 12:33:56 2026 +0100 Update header text for indirect users in report (netwrix#324) Fixes issue netwrix#323 Signed-off-by: Christian Sandfeld <csandfeld@users.noreply.github.com> commit 07fd12e Author: RichardHNetwrix <richard.hanson@netwrix.com> Date: Thu Mar 5 16:30:34 2026 +0000 PingCastle 3.5.0.44 (netwrix#326) Fix issues with Kerberos Authentication and the usage of --user and --password parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yet another small typo