Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Edit root readme #304

Merged
merged 17 commits into from
Apr 7, 2022
Merged

Edit root readme #304

merged 17 commits into from
Apr 7, 2022

Conversation

@InquestGeronimo
Copy link
Contributor

@InquestGeronimo InquestGeronimo commented Apr 4, 2022

Removed the table in the resources section as it was interfering with the docs sync. Also did some grammar edits and added a new URL for the new deepsparse.server readme.

mgoin
mgoin reviewed Apr 4, 2022
View reviewed changes
mgoin
mgoin previously approved these changes Apr 4, 2022
View reviewed changes
@InquestGeronimo InquestGeronimo self-assigned this Apr 6, 2022
jeanniefinks
jeanniefinks reviewed Apr 6, 2022
View reviewed changes
jeanniefinks
jeanniefinks reviewed Apr 6, 2022
View reviewed changes
jeanniefinks
jeanniefinks reviewed Apr 6, 2022
View reviewed changes
jeanniefinks
jeanniefinks reviewed Apr 6, 2022
View reviewed changes
jeanniefinks
jeanniefinks suggested changes Apr 6, 2022
View reviewed changes
Copy link
Member

@jeanniefinks jeanniefinks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things!
Also, and this is totally my bad: may we on line 266 correct
[**Deep Sparse Community Slack**](https://join.slack.com/t/discuss-neuralmagic/shared_invite/zt-q1a1cnvo-YBoICSIw3L1dmQpjBeDurQ)
to
**[Deep Sparse Community Slack](https://join.slack.com/t/discuss-neuralmagic/shared_invite/zt-q1a1cnvo-YBoICSIw3L1dmQpjBeDurQ)**
In the rendered html https://docs.neuralmagic.com/deepsparse/main/index.html - the bold markdown needs to go outside the link markdown. Confirm that will work when it does render again!

For other similar root README(s), we'll need to do the same. Thx!

jeanniefinks
jeanniefinks reviewed Apr 6, 2022
View reviewed changes
jeanniefinks
jeanniefinks previously approved these changes Apr 7, 2022
View reviewed changes
@InquestGeronimo InquestGeronimo requested review from rahul-tuli and removed request for rahul-tuli April 7, 2022 16:52
mgoin
mgoin reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updating model stubs to latest QA models but looks good otherwise, will accept after

@InquestGeronimo InquestGeronimo merged commit 8a0b464 into neuralmagic:main Apr 7, 2022
@InquestGeronimo InquestGeronimo deleted the edit-root-readme branch April 7, 2022 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mgoin mgoin mgoin approved these changes

@jeanniefinks jeanniefinks jeanniefinks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@InquestGeronimo InquestGeronimo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@InquestGeronimo @mgoin @jeanniefinks