Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Dec 17, 2021

Closes None.

Changes proposed:

  • Convert docstrings to numpydoc convention.
  • Add a linting GHA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #72 (6d2b9b5) into master (2858c48) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   88.61%   88.63%   +0.01%     
==========================================
  Files          10       10              
  Lines         773      774       +1     
==========================================
+ Hits          685      686       +1     
  Misses         88       88              
Impacted Files Coverage Δ
pymare/core.py 90.90% <ø> (ø)
pymare/effectsize/__init__.py 100.00% <ø> (ø)
pymare/effectsize/base.py 95.65% <ø> (ø)
pymare/effectsize/expressions.py 100.00% <ø> (ø)
pymare/estimators/__init__.py 100.00% <ø> (ø)
pymare/estimators/combination.py 92.00% <ø> (ø)
pymare/estimators/estimators.py 83.65% <ø> (ø)
pymare/stats.py 92.30% <ø> (ø)
pymare/results.py 81.81% <33.33%> (ø)
pymare/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2858c48...6d2b9b5. Read the comment docs.

@tsalo tsalo marked this pull request as draft December 17, 2021 22:30
@tsalo tsalo marked this pull request as ready for review December 18, 2021 19:09
@tsalo tsalo merged commit 9b8259b into neurostuff:master Dec 18, 2021
@tsalo tsalo deleted the numpydoc branch December 18, 2021 19:22
@tsalo tsalo added documentation Improvements or additions to documentation ignore-for-release Do not include this PR in the release notes. labels Dec 18, 2021
@tsalo tsalo mentioned this pull request Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ignore-for-release Do not include this PR in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants