Skip to content

Use LiquidsReflectometer Stitching Utilities#219

Merged
ktactac merged 1 commit intonextfrom
ewm13787-use-lrred-stitching
Feb 20, 2026
Merged

Use LiquidsReflectometer Stitching Utilities#219
ktactac merged 1 commit intonextfrom
ewm13787-use-lrred-stitching

Conversation

@ktactac
Copy link
Copy Markdown
Collaborator

@ktactac ktactac commented Feb 20, 2026

Description of work:

Previous work moved stitching functionality to lrred. This PR makes use of lrred utilities and retires refred utilities.

Check all that apply:

  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail
  • updated documentation and checked that it looks correct in the pull request preview

References:

⚠️ Manual test for the reviewer

(instructions to set up the environment)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date and looks correct in the pull request preview
  • code comments added when explaining intent

@ktactac ktactac self-assigned this Feb 20, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.96%. Comparing base (6285870) to head (f9f6bf8).

Files with missing lines Patch % Lines
src/refred/reduction/normalization_stitching.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #219      +/-   ##
==========================================
- Coverage   69.21%   68.96%   -0.26%     
==========================================
  Files         119      118       -1     
  Lines       10019     9928      -91     
==========================================
- Hits         6935     6847      -88     
+ Misses       3084     3081       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/refred/reduction/normalization_stitching.py
@ktactac ktactac merged commit 4d5ba31 into next Feb 20, 2026
6 checks passed
@ktactac ktactac deleted the ewm13787-use-lrred-stitching branch February 20, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants