Reduce data output for Diffcal and Reduction#425
Merged
dlcaballero16 merged 1 commit intostagingfrom Jul 30, 2024
Merged
Conversation
Added flag to not preserve events for DiffCal and Reduction workflows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #425 +/- ##
==========================================
Coverage ? 95.40%
==========================================
Files ? 60
Lines ? 3830
Branches ? 0
==========================================
Hits ? 3654
Misses ? 176
Partials ? 0 ☔ View full report in Codecov by Sentry. |
darshdinger
reviewed
Jul 30, 2024
darshdinger
approved these changes
Jul 30, 2024
walshmm
pushed a commit
that referenced
this pull request
Jul 30, 2024
Added flag to not preserve events for DiffCal and Reduction workflows
dlcaballero16
added a commit
that referenced
this pull request
Jul 31, 2024
Added flag to not preserve events for DiffCal and Reduction workflows
Merged
dlcaballero16
added a commit
that referenced
this pull request
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description of work
Added flag to not preserve events for DiffCal and Reduction workflows. This prevents file/workspace size from getting too big.
To test
Dev testing
On analysis, make sure you are on the staging branch. Run the diffcal workflow with the following parameters:
Run Number: 59039
Sample: La11B6_NIST_660c_001
Grouping File: Column
Peak Intensity Threshold: 0.01
Click continue. On the Tweak Peak Peek tab, set MaxChiSq to 2000, click Recalculate, and continue on all the way to the Saving tab. Before saving, inspect the output workspaces. You should see that the main output workspace takes up about 3000 MB of space. Complete the save step and verify there that the tar file and diagnostic .nxs file are at least 3 GB.
Run Normalization with the following:
Both run numbers: 59039
Sample: La11B6_NIST_660c_001
Grouping File: Column
Complete and save the results.
Run reduction with the 59039 run number and verify the workspaces with "output" in the name are about 3 GB or more.
Now repeat everything but on the reduce-data-size branch. You should not have to repeat the Normalization step. When inspecting the workspace/file size, you should see that they no longer take up 3 GB of space. The workspaces should show something like 50 MB and the tar file will be about 300 MB.
CIS testing
Same as the dev testing, just make sure all workspaces are still as expected.
Link to EWM item
EWM#6101