Skip to content

Make list of HFIR instruments complete#160

Merged
rosswhitfield merged 1 commit intonextfrom
update_hfir_instruments
May 1, 2024
Merged

Make list of HFIR instruments complete#160
rosswhitfield merged 1 commit intonextfrom
update_hfir_instruments

Conversation

@rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Apr 29, 2024

The filter on the instrument status page should now include all HFIR instruments.

hfir_filter

EWM2710

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@rosswhitfield rosswhitfield force-pushed the update_hfir_instruments branch from 8c047ed to dfa24da Compare April 29, 2024 04:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (44604d5) to head (dfa24da).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #160   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files          50       50           
  Lines        4634     4634           
=======================================
  Hits         3576     3576           
  Misses       1058     1058           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari
Copy link
Collaborator

I have tested locally by standing up the containers with make localdev/up and verified that "hb3" and other instruments in the HFIR list are now in the right category.
image

@rosswhitfield rosswhitfield merged commit f2d9a5c into next May 1, 2024
@rosswhitfield rosswhitfield deleted the update_hfir_instruments branch May 1, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants