Set LIVE_PLOT_SECRET_KEY in settings from environment#168
Merged
rosswhitfield merged 1 commit intonextfrom Jul 7, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #168 +/- ##
==========================================
- Coverage 77.07% 77.05% -0.03%
==========================================
Files 50 50
Lines 4616 4615 -1
==========================================
- Hits 3558 3556 -2
- Misses 1058 1059 +1 ☔ View full report in Codecov by Sentry. |
backmari
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LIVE_PLOT_SECRET_KEY was never set in the setting. It was only able to communicate to livedata because of a temporary bypass. This change sets the key from the environment variables.
Ref: 5923: [LiveDataServer] Change API key handling
Short description of the changes:
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References