Conversation
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
…tings Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Replaced the AMQ and PV generator services with the unified webmonchow service. Updated Dockerfiles, Docker Compose, and documentation to reflect this change, simplifying the deployment and maintenance process. Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Upgraded Miniconda from 4.12.0 to 23.3.1-0 and revised webmonchow installation. Added health check for ActiveMQ in docker-compose to enhance service reliability. Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #176 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 50 50
Lines 4626 4626
=======================================
Hits 3567 3567
Misses 1059 1059 ☔ View full report in Codecov by Sentry. |
backmari
left a comment
There was a problem hiding this comment.
The PR replaces two docker containers used by the system tests Dockerfile.amq_test_gen and Dockerfile.pv_test_gen with the new test fixture container defined in Dockerfile.webmonchow.
I can stand up the local developer environment from the docker-compose.yml and WebMon works as expected. The PV:s are updated for ARCS, HYSA and REF_M and the status of DASMON is green for the instruments.
I was able to change the templated autoreduction configuration for REF_M at http://localhost/reduction/ref_m/ and the parameter changes were reflected in the autoreduction script in the autoreducer container.
Description of the changes
Substitute services
amq_test_genandamq_pv_genwith servicewebmonchow, and update the documentation.Check all that apply:
Added unit testsAdded integration tests(If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without failReferences:
Manual test for the reviewer
Deploy locally and verify the web monitor works
Check list for the reviewer