Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #200 +/- ##
=======================================
Coverage 77.78% 77.78%
=======================================
Files 54 54
Lines 4708 4709 +1
=======================================
+ Hits 3662 3663 +1
Misses 1046 1046 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Collaborator
|
For the |
2828588 to
c6b6864
Compare
backmari
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
This fixes the two different types of warning seen coming from the models
If you check the logs the warning should no longer be there
docker logs data_workflow-webmon-1The change from
ForeignKey(unique=True, ..)toOneToOneFielddoesn't require a migration as the created table is identical.Check all that apply:
References:
Manual test for the reviewer
(Instructions for testing here)
Check list for the reviewer