Skip to content

Numpy min version#13

Merged
mpatrou merged 1 commit intonextfrom
numpy_min_v
Aug 11, 2025
Merged

Numpy min version#13
mpatrou merged 1 commit intonextfrom
numpy_min_v

Conversation

@mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Aug 11, 2025

Short description of the changes:

Set numpy min version in both pyproject.toml and recipe.yaml.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@mpatrou mpatrou requested a review from KyleQianliMa August 11, 2025 15:53
@mpatrou mpatrou self-assigned this Aug 11, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.77%. Comparing base (66b909a) to head (d9f9a20).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #13   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files          60       60           
  Lines        3524     3524           
=======================================
  Hits         2776     2776           
  Misses        748      748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@KyleQianliMa KyleQianliMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This makes the numpy version consistent with multiphonon's numpy version.

@mpatrou mpatrou merged commit bed8fac into next Aug 11, 2025
6 checks passed
@mpatrou mpatrou deleted the numpy_min_v branch August 11, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants