Skip to content

Add dev feature (e.g. pre-commit) to default pixi environment#99

Merged
peterfpeterson merged 1 commit intomainfrom
fix_pre_commit
Dec 17, 2025
Merged

Add dev feature (e.g. pre-commit) to default pixi environment#99
peterfpeterson merged 1 commit intomainfrom
fix_pre_commit

Conversation

@backmari
Copy link
Copy Markdown
Collaborator

Short description of the changes:

pre-commit wasn't run in the default pixi environment, since the dev feature, which includes pre-commit, wasn't added to the default environment. This PR adds the dev feature to the default environment to ensure pre-commit is running as expected. This also fixes linting errors (mostly line length) found by pre-commit/ruff.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (b2aa180) to head (68d6693).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
postprocessing/Consumer.py 44.44% 5 Missing ⚠️
postprocessing/processors/base_processor.py 50.00% 2 Missing ⚠️
postprocessing/processors/test_processor.py 0.00% 2 Missing ⚠️
postprocessing/reduction_script_writer.py 77.77% 2 Missing ⚠️
postprocessing/processors/reduction_processor.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files          16       16           
  Lines        1264     1264           
=======================================
  Hits         1029     1029           
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can now run pre-commit in my local checkout. I didn't realize it was not actually running on the code. Thanks for the fix.

@peterfpeterson peterfpeterson merged commit 767c088 into main Dec 17, 2025
6 of 7 checks passed
@peterfpeterson peterfpeterson deleted the fix_pre_commit branch December 17, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants