Rancher and NeuVector integration and plugin problem#207
Merged
xingzhang-suse merged 4 commits intoneuvector:mainfrom Mar 26, 2026
Merged
Rancher and NeuVector integration and plugin problem#207xingzhang-suse merged 4 commits intoneuvector:mainfrom
xingzhang-suse merged 4 commits intoneuvector:mainfrom
Conversation
…s variables (neuvector#201) Replaces all instances of the computed props rancherTheme & isLightTheme with Rancher's native CSS variables (--body-text, --modal-bg, --overlay-bg, etc.)
Replaces RANCHER_CONST.R_THEME cookie with MutationObserver mixin to read document body element
xingzhang-suse
requested changes
Mar 26, 2026
| isLightTheme: nvVariables.isLightTheme, | ||
| }; | ||
| computed: { | ||
| isLightTheme() { return !document.body.classList.contains('theme-dark'); } |
Collaborator
There was a problem hiding this comment.
isLightTheme is not used in this module.
There should be some more modules have this unused variable.
Collaborator
Author
There was a problem hiding this comment.
Oops it is a leftover artifact of refactoring. I will remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with missing
ScoreGaugeneedle.Refactors how theming is handled by the extension
agGridTheme.jsResolves #201