fix: prevent prototype pollution in objDeepCopy/objCopyProps#563
Closed
MSNev wants to merge 1 commit into
Closed
Conversation
Restrict _copyProps to only copy own properties using objHasOwnProperty and skip dangerous keys (__proto__, constructor, prototype) to prevent prototype pollution attacks during deep copy operations.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a prototype pollution vulnerability in objDeepCopy/objCopyProps by restricting copies to own properties and excluding dangerous keys (__proto__, constructor, prototype). It also adds a cross-env NODE_OPTIONS=--no-experimental-strip-types prefix to the node test scripts (presumably to keep ts-mocha working on newer Node versions).
Changes:
- In
_copyProps, guard the iteration withobjHasOwnPropertyand skip__proto__,constructor, andprototypekeys. - Import the corresponding constants and the
objHasOwnPropertyhelper. - Update
test:node/test:node_esnextto disable Node's experimental type-stripping viacross-env.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/object/copy.ts | Restrict _copyProps to own, non-dangerous properties to prevent prototype pollution. |
| package.json | Wrap node test scripts with cross-env NODE_OPTIONS=--no-experimental-strip-types to ensure ts-mocha runs correctly. |
Contributor
|
I've taken over this fix to provide a more comprehensive solutions with #565 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict _copyProps to only copy own properties using objHasOwnProperty and skip dangerous keys (proto, constructor, prototype) to prevent prototype pollution attacks during deep copy operations.