Add isLastChild and treePrefixPattern fields to beadItem for proper tree rendering #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new fields to support proper tree rendering: - isLastChild bool: indicates if this bead is the last child of its parent - treePrefixPattern string: precomputed tree prefix pattern (e.g., "│ └─") Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Modified buildBeadTree DFS to compute isLastChild and treePrefixPattern for each bead based on sibling position and ancestor continuation. Updated renderBeadLine to use the precomputed pattern instead of simple depth-based indentation. Closes: ac-ecyi, ac-v9q3, ac-pehr Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Sort roots to visit closed parents first, ensuring their open children appear under them rather than under other open parents - Filter out closed parents that end up with no visible children (when their children were already visited under different parents) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
newhook
deleted the
feat/add-islastchild-and-treeprefixpattern-fields-to-be
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new fields to the
beadItemstruct incmd/tui_shared.goto support proper tree rendering in the TUI:isLastChild bool- Indicates if a bead is the last child of its parenttreePrefixPattern string- Stores the precomputed tree prefix pattern (e.g., "│ └─")These fields enable proper visualization of tree structures in the TUI, allowing correct branch/continuation characters to be displayed during tree traversal.
Changes
isLastChildandtreePrefixPatternfields tobeadItemstruct (lines 177-178)Issues Resolved
Notes
This is a preparatory change that adds the data structure fields. A follow-up issue (ac-ecyi) will implement the computation of sibling position and ancestor continuation during the
buildBeadTreeDFS traversal.Testing
go build -o co .completes successfullygo test ./...🤖 Generated with Claude Code