Conversation
570f7b3 to
94bde7e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jachan
left a comment
There was a problem hiding this comment.
Left my 2 cents on Case's boulder as a comment on the conversation. TLDR I think it should be refactored to use the same App, but I can see why you'd keep resources in their own stack. Also had some questions about the config and why public subnets are necessary here. Great work on your first CDK PR though! It's great to see more IaaC here at the Office <3
b4f745b to
a67cf13
Compare
a67cf13 to
e8ed448
Compare
ezhangy
left a comment
There was a problem hiding this comment.
Thanks so so much for all your work here, and refactoring to make the db part of the same stack as the API!
Left several comments: some [dust/questions] that are more for my own understanding, and some [pebbles] for modifications I think we should make to the stack based on my understanding.
No one piece of feedback I had felt like it rose to the level of a [boulder], but since there are multiple potential changes here, I'd appreciate a chance to get a look over again before you merge!
e8ed448 to
1804061
Compare
jachan
left a comment
There was a problem hiding this comment.
Seems like a good starting point! Left a comment about the .gitignore that should be resolved before merge.
ezhangy
left a comment
There was a problem hiding this comment.
great work!! left some comments about removing the security groups and the VPC for this iteration before we have the public subnet set up, let me know if you have any questions
40db7f5 to
1fc0b43
Compare
ezhangy
left a comment
There was a problem hiding this comment.
looks good to me! a couple of very minor dusts, no need to ask for a re-review before merging!
so excited to see this PR cross the finish line, really great work here! 🎉
1fc0b43 to
6311351
Compare
6311351 to
7be504e
Compare
Description
This PR resolves Configure Aurora Serverless v2 PostgreSQL by implementing Infrastructure as Code (IaC) for an AWS Aurora Serverless v2 PostgreSQL database.
Approach
Using AWS Cloud Development Kit (CDK) and TypeScript:
FeedbackApiStackto accept sharedvpcandsecurityGroupfromFeedbackDbStackcdk synthto generate and validate CloudFormation outputAWS Resource Documentation
Steps to Test
npm installto install dependencies.npm run synth:devto synthesize the CDK app into a dev CloudFormation template.npm run deploy-db:devto deploy the dev database AWS.To check deployment (in AWS Console):
FeedbackDbStack.Notes