Conversation
mmazanec22
approved these changes
Aug 27, 2025
jasnoo
approved these changes
Aug 27, 2025
ezhangy
added a commit
that referenced
this pull request
Aug 29, 2025
Merges the following PR to main: - #88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ticket adds the
Access-Control-Allow-OriginandAccess-Control-Allow-Headersto the Feedback API's preflight requests. This resolves the CORS issue that caused an outage on 2025-08-26 (see outage doc).Additionally, adds units tests for the rating/comment/email Lambda handlers to check that CORS headers are being included in the response.
Testing strategy
Unit tests
npm installnpm run testSteps to test
Test the dev API deployment in the browser by running the front-end feedback widget component locally and redirecting its API requests to the dev API Gateway URL:
API_URLin feedback-widget.js to the dev API Gateway URL.feedback-widget.htmlin the browser — you should see a page containing just the frontend feedback widget component. Test that submiting a rating/comment/email works (use the network tab to ensure requests are being sent to the dev API URL and are returning a success response).Note: Submitting feedback via the widget will write to the production feedback Google Sheet. Please delete them from the sheet after testing if you have access, or ask a Platforms engineer to do so for you.
Additional resources