chore: Added OTEL rule to support Prisma 7#4013
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
==========================================
- Coverage 97.34% 97.28% -0.07%
==========================================
Files 507 507
Lines 61529 61576 +47
Branches 1 1
==========================================
+ Hits 59898 59903 +5
- Misses 1631 1673 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svetlanabrennan
approved these changes
May 20, 2026
github-project-automation
Bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
bizob2828
reviewed
May 21, 2026
| "client" | ||
| ], | ||
| "required_attribute_keys": [ | ||
| "db.system.name" |
Member
There was a problem hiding this comment.
Keep in mind that without server.address the ingest platform will not be able to build an entity relationship between the application and the db server
Contributor
Author
There was a problem hiding this comment.
I don't know what we can do about that.
Member
There was a problem hiding this comment.
I know they haven't been responsive but opening a PR to fix their otel span attrs would help
This was referenced Jun 1, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of solving #3525. In order to utilize
@prisma/instrumentationeffectively, we have to add a rule that matches Prisma's incomplete spans. Specifically, they only attach thedb.system.nameanddb.query.textattributes to their spans. Which means the lack the required attributes to match theOtelDbClient1_40rule (i.e. they are not fully following OTEL's semantic conventions).With this PR merged, and a new agent version released, I will be able to add an example app that shows how to use our OTEL support to instrument
prisma@7via their JavaScript variant and get dashboard results like: