test: Updated undici.Agent versioned test to skip using custom dispatcher on versions <5.2.0 as it was not supported#4029
Merged
Conversation
…cher on versions <5.2.0 as it was not supported
jsumners-nr
approved these changes
May 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4029 +/- ##
==========================================
- Coverage 97.39% 97.33% -0.07%
==========================================
Files 510 510
Lines 61425 61425
Branches 1 1
==========================================
- Hits 59824 59785 -39
- Misses 1601 1640 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
This was referenced Jun 1, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #4026 I added a test to verify that self signed certs with undici.Agent work. However, I didnt' test on all supported versions of undici.
It doesn't support a custom dispatcher to fetch until 5.2.0, see. This PR adds a skip for versions <5.2.0 for this test.