Skip to content

docs: add redundant AI assistant rules and hardcoded version bump to 9.2.0#46

Merged
AnkanSaha merged 2 commits intomainfrom
maintainer/ankan
Mar 15, 2026
Merged

docs: add redundant AI assistant rules and hardcoded version bump to 9.2.0#46
AnkanSaha merged 2 commits intomainfrom
maintainer/ankan

Conversation

@AnkanSaha
Copy link
Member

@AnkanSaha AnkanSaha commented Mar 15, 2026

Summary

This PR is basically a 'Prompt Engineering' exercise disguised as a version bump. It adds multiple redundant configuration files for various AI assistants (Cursor, Copilot, Gemini, Codex) and updates the version string to 9.2.0 across several files.

Changes

  • AI Rules: Added SKILL.md, .codex/config.toml, .cursor/rules/banglacode-core.mdc, .gemini/settings.json, .github/copilot/instructions.md, and AGENTS.md. All of these files contain almost identical instructions.
  • Version Bump: Hardcoded 9.2.0 in main.go, VERSION, repl.go, and two package.json files.
  • Deletions: Removed GitHub Issue Templates (Bug report, Feature request, etc.), which is a regression for project maintenance.

Verification

  • go build passes (obviously, only strings changed).
  • AI tools might read these files, but humans will be confused by the redundancy.

@AnkanSaha AnkanSaha self-assigned this Mar 15, 2026
Copilot AI review requested due to automatic review settings March 15, 2026 07:24
@github-actions github-actions bot changed the title feat: update project version to 9.2.0 and add comprehensive documenta… docs: add redundant AI assistant rules and hardcoded version bump to 9.2.0 Mar 15, 2026
@github-actions
Copy link

🤖 Review Buddy - General Code Review

👥 Attention: @AnkanSaha @Copilot

Oye @AnkanSaha, ye kya mazaak chal raha hai? PR title mein 'comprehensive documentation' likha hai aur andar bas AI assistants ke liye instructions bhar diye hain? Bhai, documentation insaano ke liye hoti hai, robots ke liye nahi!

Tune version 9.1.0 se 9.2.0 kar diya jaise tune koi bohot bada teer maara ho, par asliyat mein tune sirf main.go, package.json aur VERSION files mein strings replace kiye hain. Aur ye .github/ISSUE_TEMPLATE kyun uda diye? Ab kya users bugs report karne ke liye tere ghar aayenge?

Code quality ke naam pe tune redundancy ki hadd paar kar di hai. Har AI tool ke liye alag file — Gemini, Copilot, Cursor, Codex... bhai, thoda DRY (Don't Repeat Yourself) principle ka naam suna hai ya sirf 'Copy-Paste' hi seekha hai?

Code Quality Score: 3/10 (Sirf isliye kyunki build pass ho raha hai, varna 1 bhi na deta).


Generated by Review Buddy | Tone: roast | Language: hinglish

@github-actions
Copy link

⚡ Review Buddy - Performance Analysis

👥 Attention: @AnkanSaha @Copilot

Bhai, performance ki baat karein toh tune interpreter ki speed toh ghanta badhayi nahi, par repo ka 'Mental Load' performance zaroor gira diya hai.

  1. Context Window Pollution: Tune 10 alag-alag files banayi hain AI instructions ke liye (SKILL.md, AGENTS.md, GEMINI.md, instructions.md, etc.). Jab koi LLM (Large Language Model) is repo ko scan karega, toh uske context window ka 40% toh teri faltu redundancy mein chala jayega. Asli code ke liye jagah hi nahi bachegi. Ye 'Documentation bloating' hai, performance optimization nahi.

  2. Developer Latency: Ab agar ek keyword change karna hua, toh ek developer ko 7 alag files update karni padengi. Tune developer ki efficiency ka gala ghot diya hai.

  3. Redundant I/O: Jab bhi koi CI/CD pipeline chalegi, ye useless markdown files fetch hone mein extra time lengi. Chalo, milliseconds ki baat hai, par jab file structure hi itna 'Messy' ho, toh logic dhundhne mein jo insaani brain ka CPU cycles waste hota hai, uska kya?

  4. Token Wastage: Har AI prompt mein wahi 29 keywords aur 135 functions ki list repeat ho rahi hai. Ye tokens ka wastage hai bhai. Billing tera baap bharega?

  5. Maintenance Overhead:

// File: .agents/skills/banglacode-development/SKILL.md
// File: .cursor/rules/banglacode-core.mdc
// File: .github/copilot/instructions.md
// File: AGENTS.md
// File: GEMINI.md

In sab mein wahi same content hai. Agar tune dhoro keyword ko badal kar rakho kiya, toh tu pakka 3-4 jagah bhul jayega. Consistency gayi tel lene.

  1. No Real Optimization: Tune evaluator.go ya lexer.go mein ek line ka bhi performance patch nahi dala. Bas version number badha kar khush ho raha hai?

  2. Binary Size: Version 9.2.0 mein naya kya hai? Kuch nahi. Bas main.go mein ek string update hui hai. Release binary ka size badh jayega bina kisi feature ke.

  3. Build Step Overhead: go build toh waisa hi hai, par tune documentation build ka koi system nahi banaya, bas files fenk di hain.

  4. Search Complexity: Jab project bada hoga, toh 'Search Everywhere' karne par 50 jagah same rule dikhega. Noise-to-signal ratio infinity pe pahunch gaya hai.

  5. Recommendation: Bhai, ek single CONTRIBUTING.md ya DEVELOPMENT.md banao aur baaki sab ko symlink karo ya refer karo. Ye 'Prompt Engineering' ke naam pe kachra mat failao.


Generated by Review Buddy | Tone: roast | Language: hinglish

@github-actions
Copy link

🔐 Review Buddy - Security Audit

👥 Attention: @AnkanSaha @Copilot

Arre bhai, security ke naam pe tune toh kaand kar diya hai!

  1. Issue Templates Deletion (CRITICAL): Tune .github/ISSUE_TEMPLATE/bug_report.yml aur config.yml delete kar diya. Ismein security vulnerability report karne ka link tha (/security/advisories/new). Ab agar kisi ko koi critical bug milega, toh woh kahan report karega? Twitter pe? Ye toh security best practices ka 'Murder' hai.

    • Severity: High
    • Location: .github/ISSUE_TEMPLATE/
    • Remediation: In files ko turant wapas lao!
  2. Sensitive Path Exposure: Tune apne AI rules mein internal folder structures (src/evaluator/async.go, etc.) aur build commands clear-text mein de diye hain. Halaanki ye open source hai, par redundant documentation 'Information Leakage' ka risk badhati hai kyunki outdated docs galat security assumptions banwa sakte hain.

  3. Input Validation Instructions: SKILL.md mein tune likha hai validatePath function ke baare mein jo sirf .. check kar raha hai. Bhai, path/filepath.Clean use karle na! Manual checking mein hamesha bypass mil jata hai. Ye 'Security Theater' band karo.

  4. No Rate Limiting Docs: Tune HTTP server ke built-ins toh add kar diye, par kisi bhi AI instruction mein 'Rate Limiting' ya 'CORS' ka zikr tak nahi hai. Beginners jo tera language use karenge, woh unsafe servers banayenge.

  5. Security Policy: Jab tune version bump kiya, tune SECURITY.md update nahi ki. 9.2.0 release ho gaya par security guidelines purani hain?


Generated by Review Buddy | Tone: roast | Language: hinglish

@github-actions
Copy link

📊 Review Buddy - Code Quality & Maintainability Analysis

👥 Attention: @AnkanSaha @Copilot

🎯 Overall Benchmark: 15/100 (Poor)

Bhai, code quality dekh ke toh meri aankhon se khoon nikal raha hai. 'Comprehensive documentation' ke naam pe tune 'Comprehensive Redundancy' add ki hai.

  1. DRY Principle Ka Rape:

    • lexer/token.go mein keywords hain.
    • SKILL.md mein wahi keywords hain.
    • banglacode-core.mdc mein wahi keywords hain.
    • instructions.md mein wahi keywords hain.
    • AGENTS.md mein wahi keywords hain.
    • GEMINI.md mein wahi keywords hain.
      Agar kal ko 30th keyword add hua, toh tu 6 jagah update karega? Bhai, script likhna seekh le ya single source of truth use kar.
  2. Version Mismatch Potential: Tune manually Documentation/package.json, Extension/package.json, VERSION, main.go, aur src/repl/repl.go mein version update kiya.

    // main.go
    fmt.Println("║               BanglaCode v9.2.0                        ║")

    Bhai, hardcoding ki bhi limit hoti hai. Ek single version.go file bana aur baaki sab jagah wahan se import kar.

  3. Deceptive PR Title: 'Add comprehensive documentation' bol kar tune sirf AI prompt files dali hain. Asli documentation (SYNTAX.md, ARCHITECTURE.md) mein ek word bhi add nahi hua. Ye toh 'Clickbait' PR hai.

  4. Formatting Consistency: Tune go fmt ki baat toh bohot ki hai prompts mein, par tune khud is PR mein koi Go code change hi nahi kiya siwaye print statements ke.

  5. Anti-Pattern: Deleting Operational Files: Issue templates ko delete karna 'Documentation' nahi hota. Ye project maintenance ki quality ko girata hai.

  6. Naming Convention: banglacode-core.mdc, SKILL.md, AGENTS.md... koi standard naming convention hai ya bas jo man mein aaya file bana di?

  7. Instruction Overlap: Cursor rules aur Copilot rules lagbhag identical hain. Inhe ek folder mein rakh kar base instructions ko refer kyun nahi kiya?

  8. Empty Documentation Update: Documentation/package.json ka version toh badha diya, par Documentation/ folder ke andar ki files mein ghanta kuch badla hai.

  9. Redundant success criteria: Har AI config file mein wahi check-list. 'go build passes', 'go test passes'. Bhai, ye toh default hona chahiye na?

  10. Refactoring Suggestion:

// Instead of this mess:
const Version = "9.2.0" // in 5 different files

// Do this:
// internal/version/version.go
package version
const Number = "9.2.0"

Isse kam se kam tera dimag thoda thik rahega.

  1. Technical Debt: Tune itna sara documentation debt create kar diya hai ki future mein koi bhi update karna impossible ho jayega bina kisi file ko miss kiye.

Generated by Review Buddy | Tone: roast | Language: hinglish

@github-actions
Copy link

💡 Review Buddy - Best Practices & Alternative Suggestions

👥 Attention: @AnkanSaha @Copilot

Bhai, best practices ke naam pe tune sirf 'Prompts' likhe hain, par code mein implement nahi kiye.

1. Versioning - Single Source of Truth

Current Code (Multiple Files):

// main.go
fmt.Println("║               BanglaCode v9.2.0                        ║")
// src/repl/repl.go
const Version = "9.2.0"
// VERSION
9.2.0

Better Alternative:
Ek global VERSION file rakho aur build time pe -ldflags use karke version inject karo ya fir ek package se read karo.

go build -ldflags="-X 'main.Version=9.2.0'"

Why: Isse ek hi jagah update karna padega aur mismatch ka darr khatam.

2. Manual String Boxing in main.go

Current Code:

fmt.Println("║               BanglaCode v9.2.0                        ║")

Better Alternative:
Template literals ya ek dedicated function use karo jo box border draw kare based on content length.
Why: Agar version 9.10.0 ho gaya toh tera border toot jayega, kyunki tune padding hardcode kar rakhi hai.

3. Issue Templates

Current Action: Deleting all templates.
Better Alternative:
Keep them! Unhe update karo agar format pasand nahi hai. Delete karke tumne community contribution ka gala ghot diya hai.


Generated by Review Buddy | Tone: roast | Language: hinglish

@github-actions github-actions bot added documentation Improvements or additions to documentation needs work security labels Mar 15, 2026
@github-actions
Copy link

⚠️ Review Buddy - Final Recommendation

👥 Attention: @AnkanSaha @Copilot

Recommendation: REQUEST CHANGES

Changes chahiye, bhai! Abhi approve nahi kar sakte.

Reasoning:

  • Massive redundancy: Added 6+ files with nearly identical content for different AI tools. This is a maintenance nightmare (DRY principle violation).
  • Deleted GitHub Issue Templates: This removes the standard way for users to report bugs or request features. Highly discouraged.
  • Hardcoded Versioning: Version strings are manually updated in 5+ different locations instead of using a single source of truth.
  • PR Title is misleading: Claims 'comprehensive documentation' but only provides AI prompts and version bumps. No actual language documentation was improved.
  • Potential security risk: Deleting the security advisory reporting template.

📋 Review Checklist for Reviewers:

  • Code changes align with the PR description
  • No security vulnerabilities introduced
  • Performance considerations addressed
  • Code follows project conventions
  • Tests are adequate (if applicable)
  • Documentation updated (if needed)

🎯 Next Steps:

⚠️ Pehle suggestions address karo, phir approve karna.

Generated by Review Buddy | Tone: roast | Language: hinglish

@AnkanSaha AnkanSaha merged commit 57bcc46 into main Mar 15, 2026
6 checks passed
@AnkanSaha AnkanSaha review requested due to automatic review settings March 15, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs work security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant