Faster function to load MC hits #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmkekic
reviewed
Oct 18, 2019
Collaborator
mmkekic
left a comment
mmkekic
left a comment
There was a problem hiding this comment.
Since most of the code in both function is just a copy from read_mcinfo_evt and read_mcinfo, isnt it better to have a flag in those function as return_only_hits = False and make a minimal change to continue the loop if particle and generator information is not needed?
Collaborator
Author
|
Ok, I added a flag to the |
mmkekic
reviewed
Oct 18, 2019
Collaborator
mmkekic
left a comment
mmkekic
left a comment
There was a problem hiding this comment.
I think after this changes this PR can be approved
paolafer
force-pushed
the
new-load-mc-hit-function
branch
from
d1012f3 to
3420d4f
Compare
mmkekic
approved these changes
Oct 21, 2019
Collaborator
mmkekic
left a comment
mmkekic
left a comment
There was a problem hiding this comment.
This PR adds a more efficient way to read mchit info only from MC tables, with a minimal change to existing functions. Good job :)
carmenromo
pushed a commit
that referenced
this pull request
Oct 21, 2019
#654 [author: paolafer] In this PR I changed the function called by `load_mchits()`, which loads the true MC hits of a range of events in a file. The previous function loads all the true information (including particles) and returns only hits, while this function loads only the hits. The time is reduced to ~75% of the original time, for a file of ~8000 events of 511-keV gamma interactions, therefore I thought that this new implementation could be worth it. I haven't added any test, because we have already a test for the `load_mchits() function, which uses internally the new function. This change should be transparent to the user. [reviewer: mmkekic] This PR adds a more efficient way to read mchit info only from MC tables, with a minimal change to existing functions. Good job :)
andLaing
pushed a commit
to andLaing/IC
that referenced
this pull request
May 13, 2020
next-exp#654 [author: paolafer] In this PR I changed the function called by `load_mchits()`, which loads the true MC hits of a range of events in a file. The previous function loads all the true information (including particles) and returns only hits, while this function loads only the hits. The time is reduced to ~75% of the original time, for a file of ~8000 events of 511-keV gamma interactions, therefore I thought that this new implementation could be worth it. I haven't added any test, because we have already a test for the `load_mchits() function, which uses internally the new function. This change should be transparent to the user. [reviewer: mmkekic] This PR adds a more efficient way to read mchit info only from MC tables, with a minimal change to existing functions. Good job :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I changed the function called by
load_mchits(), which loads the true MC hits of a range of events in a file. The previous function loads all the true information (including particles) and returns only hits, while this function loads only the hits. The time is reduced to ~75% of the original time, for a file of ~8000 events of 511-keV gamma interactions, therefore I thought that this new implementation could be worth it. I haven't added any test, because we have already a test for theload_mchits()function, which uses internally the new function. This change should be transparent to the user.