Skip to content

Conversation

@jacg
Copy link
Collaborator

@jacg jacg commented Jun 23, 2020

Travis has been failing on OSX since we enabled Git LFS.

This is becasue Travis enables LFS on its Linux images but not on the OSX ones.

This PR fixes the problem by using brew to install Git LFS on the OSX image.

Closes #552.

@jacg jacg requested a review from jmbenlloch June 23, 2020 11:28
@jacg
Copy link
Collaborator Author

jacg commented Jun 27, 2020

@jjgomezcadenas Is there any good reason to delay the review and merging of this almost trivial PR?

Copy link
Contributor

@jmbenlloch jmbenlloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix to get OSX working again on Travis.

@bpalmeiro bpalmeiro merged commit 88655da into next-exp:master Jun 27, 2020
@jacg jacg deleted the fix-lfs-on-travis-mac branch June 27, 2020 16:56
@jacg jacg mentioned this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis failing on OS X, post LFS

3 participants