Update beersheba related tests after package updates #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaponte
approved these changes
Jul 17, 2020
Collaborator
gonzaponte
left a comment
gonzaponte
left a comment
There was a problem hiding this comment.
Scipy interpolate changed behavior in the recent package upgrade. The exact methodology change hasn't been found in the changelog, which is annoying. The differences in the values obtained in the tests vary around the percent level, but the overall performance of the algorithm hasn't been affected, according to @Aretno. Thus, the update simply relies on freezing these new values, hoping that they will not change again in a future release of scipy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating some packages in #723 there were some test that were marked as skipped after checking final result did not change performance-wise. This PR aims to update the values of the test so they can be enabled again.