[pull] master from kubernetes:master#253
Merged
pull[bot] merged 10 commits intonext-stack:masterfrom Apr 13, 2019
Merged
Conversation
Mostly by using the "extract method" pattern. Here was the report (from gocyclo), before: 16 kubeadm (*KubeadmBootstrapper).UpdateCluster pkg/minikube/bootstrapper/kubeadm/kubeadm.go:374:1 16 cluster StartHost pkg/minikube/cluster/cluster.go:64:1 16 tunnel setupRoute pkg/minikube/tunnel/tunnel.go:135:1 16 provision configureAuth pkg/provision/buildroot.go:218:1 21 util setElement pkg/util/config.go:50:1
Mostly by using the "extract method" pattern. Here was the report (from gocyclo), before: 17 tunnel TestTunnelManagerCleanup pkg/minikube/tunnel/tunnel_manager_test.go:174:1 44 tunnel TestTunnel pkg/minikube/tunnel/tunnel_test.go:35:1 34 kubeconfig configEquals pkg/util/kubeconfig/config_test.go:420:1 25 integration testMounting test/integration/mount_test.go:36:1 18 integration testTunnel test/integration/tunnel_test.go:37:1
16 config EnableOrDisableAddon cmd/minikube/cmd/config/util.go:105:1
17 cmd runStart cmd/minikube/cmd/start.go:165:1
ineffassign: 99% pkg/minikube/service/service.go Line 175: warning: ineffectual assignment to err
Decrease cyclomatic complexity
Fixed ignored error, noticed by ineffassign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]