[pull] master from moby:master#917
Merged
pull[bot] merged 5 commits intonext-stack:masterfrom May 8, 2020
Merged
Conversation
This version avoids doing name lookups on creating tarball that should be avoided in to not hit loading glibc shared libraries. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit aa6a989) Signed-off-by: Tibor Vass <tibor@docker.com>
This blurb exists because we reused the same commit from an old patch, and thus got the commit message with it. However the message is confusing in this context. It was suggested in review that we should remove the confusing message. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This prevents getting into a situation where a container log cannot make progress because we tried to rotate a file, got an error, and now the file is closed. The next time we try to write a log entry it will try and rotate again but error that the file is already closed. I wonder if there is more we can do to beef up this rotation logic. Found this issue while investigating missing logs with errors in the docker daemon logs like: ``` Failed to log message for json-file: error closing file: close <file>: file already closed ``` I'm not sure why the original rotation failed since the data was no longer available. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
logfile: Check if log is closed on close error during rotate
vendor: add local copy of archive/tar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )