[pull] master from badges:master#1
Merged
pull[bot] merged 309 commits intonext-stack:masterfrom Jul 25, 2018
Merged
Conversation
- Restore correct list of styles to markup modal - DRY lists of styles Fix #1330
Reference: #819
Using fix from mapbox/react-click-to-select#15. From #1273
I don’t like that our build goes red on master all the time due to flaky service tests. I thought I’d look into other CI services that would make it possible to run the scheduled tests nightly without causing those messages to show up. CircleCI, Heroku CI, and Codeship were obvious choices. Heroku CI wasn’t free and I didn’t have any experience with Codeship, so I looked into CircleCI. I’ve used their 1.0 system a lot though this was my first time on their 2.0 system. As with earlier versions, they’ve put a lot of work into making the build fast – perhaps more than any other CI system I’ve seen. I had such good results, my goal shifted from scheduled daily builds (that don’t litter our commit history with red builds) to improving the CI experience as a whole. This change made a big impact: - Build logs load much, much faster. In the test I just ran, 22 seconds to < 2 seconds, a 90% improvement. - Status of each step shows up right in the GitHub UI, which makes it much faster to see exactly what’s failed. - Builds run about 50-75% faster on account of parallelism. - GitHub service tests are fixed. This has been a long-standing issue. - Ability to ssh into a build container to debug failures. Here’s what I did: - Created custom Docker images with our dependencies. To be honest, I’m not even sure these are necessary, only to install the greenkeeper-lockfile. We could get dejavu from npm. They make startup very fast. - Created an npm-install stage which loads all dependencies into node_modules and caches them. - Created separate stages for our main tests, service tests, and frontend tests, and stages to run the main tests and service tests in Node 6. These run in parallel, up to four at a time. - Separated service test ID output from the service test results themselves. (I check these often during the PR process, when I confirm that service tests actually ran. Because the production Shields server caches the title, after updating it you can’t tell whether the update is taking effect.) - Added a personal access token for the shields-ci user. This should actually fix the long-standing issue #979. CircleCI provides an option to “Pass secrets to builds from forked pull requests,” which means unlike Travis, they’ll give us enough rope to shoot ourselves in the foot. - Schedule a daily build, which runs all the service tests.
…1284) * fix vs market colors * fix tests & update formatting Fix tests Update tests file formatting to be consistant with other tests * update tests labels * switch case formatting * add stars rating * add tests for stars
… so we can stop saying "you forgot to…" in code review. 😀 This idea has come up a number of times. If we can write code to detect a contributor guideline, this tool will message the contributor automatically in a pull request. This lets people fix their own problems, relieves maintainers and reviewers from nagging, and keeps anyone from having to constantly ask for more tests. For futher reading: - [How to use Danger well](http://danger.systems/js/usage/culture.html) - [Examples of the kind of thing it can do](http://danger.systems/js/) - [Dangerfile reference](http://danger.systems/js/reference.html)
…1354) * Add service tests for bountysource badge * switch to use ES6 style variable declarations * Fail cleanly on bad responses.
IcedFrisby/IcedFrisby#71 will allow us to set a per-test `timeout()` and per-test `retry()`, which should allow us to keep flaky tests green most of the time. A slough of service tests are failing locally, though they are also failing in master and seem unrelated to these changes. (#1359) IcedFrisby is maturing toward a 2.0 API. There's been one breaking change to the way dependencies are installed, and probably more changes to come in the API itself. Shields uses such a small part of that API that 2.0, when it's released, may not even affect us.
As argued for in #1314 (comment). It populates large quantities of text in the logs, where I wish to only see errors.
Extracted from the TFS built-in badges that are already SVG.
* Removed hasPrefix method and added tests to cover prependPrefix
I have a branch going to automatically generate stats on which services have tests, and make a line chart over time. I'm having a lot of fun with that so I'll keep at it. Meanwhile, here is my subjective list of critical services, for #1358.
* Add Jenkins Jacoco coverage badge * [Jenkins] add service test for jacoco coverage * Added Jenkins Coverage (Jacoco) in all-badge-examples page * Defined variables using let/const instead of var * Used template string for the uri * Used checkErrorResponse helper function for the error check * Used NaN method for not a number test * Prefixed the original Jenkin coverage test with "cobertura:" * Moved the happy test case at front * Merge the business logic between jacoco and cobertura * Fixed lint issue * Trigger notification
* Add docker logo
* add support for rgb, rgb, css named colors * add support for hsl, hsla & add color-validate * update makeBadge test, better coverage * re-add comment * add comment for supported colors * dynamic badge gen, remove 'hex' * add support for 1.0 opacity & fix 101-109 * fix colorscheme tests * remove extra tests * add test for negative values * add test for uppercase & mixed case colors * fix mixed case/uppercase test * allow whitespace around color * update test error messages * add comments * add more uppercase test * update error message * default to grey/red if invalid color chosen default colorscheme: colorA: grey colorB: red * Revert "default to grey/red if invalid color chosen" This reverts commit 10db0c6. Reverted as this affects the CLI version/when no color specified. * validColor -> isCSSColor * assignColor function * update tests to use sazerac
This was designed as part of a rewrite of the Github auth code in #1205 which is stalled because I don't want to deploy it without access to server logs. The need for token rotation came up recently in #541, so I picked up this code, removed the github-specific bits, and pulled it in. Ordinarily I wouldn't merge helper code without a use, though sadly it seems like the best way to move forward this rewrite.
* deprecate Magnum CI badge * deprecate BitHound badges
* chore(package): update prettier to version 1.13.6 * Update lockfile
…readthedocs scrutinizer shippable travis] Extracted isBuildStatus test validator (#1767)
* fix for invalid [jenkins] tests
* chore(package): update eslint-plugin-node to version 7.0.0 * Update lockfile * Update call to deprecated API
This addresses some long-standing comments in #1458 (comment) We should also adopt Gatsby, create-react-app, or something similar designed for static sites, to eliminate the unnecessary runtime dependency on Next.js while also letting someone else maintain our front-end tooling. :-D These alternative tools might work just fine in subdirectories without config, and we might be able to leave Jekyll turned on (though we don’t need it). However these git-related changes are orthogonal. - Don’t check out master, making it possible to deploy the currently checked-out commit - Disable Jekyll which we don’t need. This allows _next folders to be deployed, and the related URL rewriting to be removed. - Completely empty the deploy branch’s index before deployment. This prevents errors from broken symlinks, while preserving the commit history in the deploy branch. - Do the deployment work in a git working tree. This requires Git 2.18 but makes it possible to do the above very safely.
* tell browsers and downstream caches to cache for `env.BADGE_MAX_AGE_SECONDS`, default 0 for dev * set Cache-Control: no-cache, no-store, must-revalidate if maxAge=0 * add servertime badge to help with cache header debugging * if service category is 'debug', exclude from examples * ignore maxAge GET param if less than `env.BADGE_MAX_AGE_SECONDS`
Service detection didn’t work correctly for PR titles with multiple bracketed entries. https://circleci.com/gh/badges/shields/6797
This causes extremely strange failures in CircleCI. `npm install`, oddly, rewrites and reformats package.json. We hash package.json to determine the cache keys, and oddly enough Circle computes a new hash when we write the cache. `npm-install` writes to one cache key. The tasks that follow read from another. Nothing runs. I'm running into this because I'm using prettier auto-format on another project, and the presence of a `.prettierrc` means it's started trying to format Shields code. In separate news, I'm loving auto-formatting!
* Test handling of invalid JSON on BaseJsonService * Remove invalidJSON tests from new-style services
Re-organise badge examples into categories: - Build - Chat - Dependencies - Downloads - Funding - Issue Tracking - License - Rating - Social - Version - Other
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]