3단계 - 의존성 리팩터링 #530
Merged
3단계 - 의존성 리팩터링 #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 제거 및 orderTableId를 통한 간접 참조로 로직 변경
enemfk777
approved these changes
Jun 29, 2022
|
|
||
| ### 의존도 draw | ||
| - Before(https://github.com/tyakamyz/jwp-refactoring/blob/step3/docs/refactor-before.drawio.png) | ||
| - After(https://github.com/tyakamyz/jwp-refactoring/blob/step3/docs/refactor-after.drawio.png) |
There was a problem hiding this comment.
의존성은 변하기 쉬운 것이 변하지 않는 것을 의존하는 방향으로 흘러가는 편이 안정적입니다.
(presentation -> service -> domain 방향으로 의존하는 것 처럼 말이죠 :))
이를 각 도메인 간의 관계에도 적용 해 볼 수 있을 것 같은데요
table에 비해 order는 쉽게 변할 수 있는 변경이 잦은 도메인으로 보입니다.
헌데 지금은 table이 order에 의존하고 있네요
인터페이스를 이용해서 의존성을 역전해보시면 어떨까요?
인터페이스는 table 도메인에 두고, 구현체를 order 쪽이 가져간다면, 의존성이 역전 될 수 있을 것 같아요 :)
Author
There was a problem hiding this comment.
조언 감사드립니다!
말씀해주신 내용 적용해보겠습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님
3단계 - 의존성 리팩터링 PR 드립니다 :)
의존도를 머릿속 계산만으로는 그려지지가 않아서... 그림을 그리고 시작했습니다
리팩토링하면서도 그림을 업데이트 해가며 작업했습니다
그럼 이번 리뷰도 잘 부탁드리겠습니다!
Before
After