Skip to content

Conversation

@hillac
Copy link
Contributor

@hillac hillac commented Jul 31, 2024

☕️ Reasoning

Add some explanation on ESM for the express integration. There's been a few discussions with people being tripped up by ESM vs CommonJS module config.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

#11417
#11280
#10507

📌 Resources

@hillac hillac requested a review from ThangHuuVu as a code owner July 31, 2024 12:39
@vercel
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 0:40am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 0:40am

@vercel
Copy link

vercel bot commented Jul 31, 2024

Someone is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.10%. Comparing base (cd5ab90) to head (55dad98).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11492      +/-   ##
==========================================
+ Coverage   40.08%   40.10%   +0.01%     
==========================================
  Files         179      179              
  Lines       28739    28748       +9     
  Branches     1254     1260       +6     
==========================================
+ Hits        11519    11528       +9     
  Misses      17220    17220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balazsorban44 balazsorban44 merged commit 0dcd737 into nextauthjs:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants