Skip to content

chore(adapters): Add next-autth as devDependencies for adapters #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndom91 merged 4 commits into from
Mar 21, 2022
Merged

chore(adapters): Add next-autth as devDependencies for adapters #4226

ndom91 merged 4 commits into from
Mar 21, 2022

Conversation

@ThangHuuVu
Copy link
Member

@ThangHuuVu ThangHuuVu commented Mar 20, 2022

Reasoning 💡

  • turborepo recently made changes so that peerDependencies are not getting prioritized in the topological order in their v1.1.6 release. This makes our build fails because adapters are being built in parallel with core next-auth.
  • Follow up fix: set module to commonjs for adapters #4205, this PR improves the codebase by adding next-auth as devDependencies for all adapter modules. This should help priotizing next-auth to being built first.

Checklist 🧢

  • [ ] Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

@vercel
Copy link

vercel bot commented Mar 20, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/EMnmgZNAQtZYjtzw4EBo7m8qAvgV
✅ Preview: Canceled

[Deployment for 2a33e49 canceled]

@github-actions github-actions bot added core Refers to `@auth/core` dgraph @auth/dgraph-adapter dynamodb @auth/dynamodb-adapter fauna @auth/fauna-adapter firebase @auth/firebase-adapter mikro-orm @auth/mikro-orm-adapter mongodb @auth/mongodb-adapter neo4j @auth/neo4j-adapter pouchdb @auth/pouchdb-adapter prisma @auth/prisma-adapter sequelize @auth/sequelize-adapter typeorm @auth/typeorm-adapter upstash-redis @auth/upstash-redis-adapter labels Mar 20, 2022
ThangHuuVu
ThangHuuVu commented Mar 20, 2022
View reviewed changes
packages/tsconfig/adapters.json
"compilerOptions": {
"target": "ES2019",
"module": "commonjs",
"declaration": true,
Copy link
Member Author

@ThangHuuVu ThangHuuVu Mar 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove these configs because these configs are present in base.json. Let's see if it breaks the build 🤔

@ThangHuuVu ThangHuuVu marked this pull request as ready for review March 20, 2022 13:37
ndom91
ndom91 approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@ndom91 ndom91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Man this monorepo stuff ain't simple 😅

@ThangHuuVu
Copy link
Member Author

ThangHuuVu commented Mar 20, 2022

@ndom91 fantastic! Can you help me merge it? 🙏

@ndom91
Copy link
Member

ndom91 commented Mar 20, 2022

@ndom91 fantastic! Can you help me merge it? 🙏

Yeah, I'll be online again in an hour or so. But balazs recently removed the hard coded 'dry-run' in the release script.

So theoretically it should merge and release successfully via built-in GH action.

We can do it together later though if you want 👍

@balazsorban44
Copy link
Member

balazsorban44 commented Mar 21, 2022

This won't release anything, as:

  1. releases need manual approval in GH actions
  2. type is chore, so should be safe 👍

@ndom91
Copy link
Member

ndom91 commented Mar 21, 2022 •
edited
Loading

This won't release anything, as:

  1. releases need manual approval in GH actions
  2. type is chore, so should be safe +1

Ah okay thanks! Forgot about the chore prefix not publishing. Then i'll merge this now 👍

@ndom91 ndom91 merged commit 6e28ccf into nextauthjs:main Mar 21, 2022
@ThangHuuVu ThangHuuVu deleted the chore/adapters-dev-deps branch March 22, 2022 01:25
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
@mnphpexpert
chore(adapters): Add next-autth as devDependencies for adapters (next…
8211fd8 
…authjs#4226)

* Upgrade turborepo, add next-auth as dev deps

* Fix TS error

* Update adapters.json

* ignore linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndom91 ndom91 ndom91 approved these changes

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44 balazsorban44 is a code owner

@0ubbe 0ubbe Awaiting requested review from 0ubbe

Assignees

No one assigned

Labels

core Refers to `@auth/core` dgraph @auth/dgraph-adapter dynamodb @auth/dynamodb-adapter fauna @auth/fauna-adapter firebase @auth/firebase-adapter mikro-orm @auth/mikro-orm-adapter mongodb @auth/mongodb-adapter neo4j @auth/neo4j-adapter pouchdb @auth/pouchdb-adapter prisma @auth/prisma-adapter sequelize @auth/sequelize-adapter typeorm @auth/typeorm-adapter upstash-redis @auth/upstash-redis-adapter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThangHuuVu @ndom91 @balazsorban44