check oidc account types in callback-handler.ts#6108
Merged
balazsorban44 merged 3 commits intonextauthjs:mainfrom Dec 18, 2022
Merged
check oidc account types in callback-handler.ts#6108balazsorban44 merged 3 commits intonextauthjs:mainfrom
balazsorban44 merged 3 commits intonextauthjs:mainfrom
Conversation
|
@amanzanero is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
balazsorban44
approved these changes
Dec 18, 2022
Member
balazsorban44
left a comment
There was a problem hiding this comment.
Thanks. Reverted the unrelated change. We will refactor account handling. For now, just update your own schema accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Context can be found in linked issue, but this fixes a bug where using
packages/core/src/providers/google.ts:next-auth/packages/core/src/providers/google.ts
Line 27 in 2e924ed
with
@auth/corethrows anUnsupported account type errornote Another thing I had to do was update my prisma schema for
Account(in my personal project) to includeexpires_in, and I included that in this diff but I am certain that it isn't exhaustive and may need more updates in more documentation.🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: #6105
📌 Resources