Skip to content

check oidc account types in callback-handler.ts#6108

Merged
balazsorban44 merged 3 commits intonextauthjs:mainfrom
amanzanero:main
Dec 18, 2022
Merged

check oidc account types in callback-handler.ts#6108
balazsorban44 merged 3 commits intonextauthjs:mainfrom
amanzanero:main

Conversation

@amanzanero
Copy link
Copy Markdown
Contributor

@amanzanero amanzanero commented Dec 17, 2022

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

Context can be found in linked issue, but this fixes a bug where using packages/core/src/providers/google.ts:


with @auth/core throws an Unsupported account type error

note Another thing I had to do was update my prisma schema for Account (in my personal project) to include expires_in, and I included that in this diff but I am certain that it isn't exhaustive and may need more updates in more documentation.

🧢 Checklist

  • Documentation (kinda)
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: #6105

📌 Resources

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 17, 2022

@amanzanero is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 17, 2022 at 8:43PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth ⬜️ Ignored (Inspect) Dec 17, 2022 at 8:43PM (UTC)

Copy link
Copy Markdown
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Reverted the unrelated change. We will refactor account handling. For now, just update your own schema accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@auth/core signing in with GoogleProvider while using Adapter throws "Unsupported account type"

2 participants