@auth/remix framework for using @auth in remix#6270
@auth/remix framework for using @auth in remix#6270acoreyj wants to merge 0 commit intonextauthjs:mainfrom
Conversation
|
@acoreyj is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Thanks for the PR! As a preliminary review to set some expectations, I would like to point out that we should aim to embrace the framework as much as possible, rather than reusing code from other framework implementations. I'll have to dig deeper into Remix, but I have a feeling that the current client module is not the "Remix-way". We could merge it for now, but will have to improve before hitting a stable release version.
| @@ -0,0 +1,16 @@ | |||
| import path from "path"; | |||
There was a problem hiding this comment.
I don't think, this file should be needed.
| "@auth/core": "workspace:*", | ||
| "@types/node": "^18.7.14", | ||
| "next-auth": "workspace:*", | ||
| "tsup": "^6.5.0", |
There was a problem hiding this comment.
let's not add another tool. we already have tsc, let's remove this
There was a problem hiding this comment.
Hmm I'll make the change but just fyi I based it off
https://github.com/nextauthjs/next-auth/tree/main/packages/frameworks-solid-start
There was a problem hiding this comment.
thanks for the heads up, we should do the same there too. 👍
There was a problem hiding this comment.
solid start is now using tsc instead of tsup aswell
| @@ -0,0 +1,14 @@ | |||
| import { defineConfig } from "tsup"; | |||
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "extends": "./tsconfig.json", | |||
There was a problem hiding this comment.
should only have single tsconfig, let's remove this. the eslint config is in the root directory
Hmm good call I think I can adapt to using the createCookieSessionStorage function from remix |
balazsorban44
force-pushed
the
main
branch
6 times, most recently
from
19c6807 to
3be7bb7
Compare
github-actions
bot
added
core
github-actions
bot
removed
the
legacy
|
This is pretty much working but I'm hoping on seeing some bug fixes in upcoming remix releases that this needs so patches aren't needed. Specifically remix-run/react-router#9913 |
|
@acoreyj - is the auth.js adapter for remix still something you'd want to tackle after those bug fixes you mentioned are resolved? Currently using Remix Auth to get Azure Authentication working, but would love to get it working with Auth.js Remix adapter 😄 |
|
Yea I have actually been using it myself by using patch-package to implement the change from the remix PR if that's something you want to do. See the new MR at #6767 and checkout the README.md in the files changed |
4 participants
MOVED TO #6767