fix(docs): fix failing docs build#8463
Merged
balazsorban44 merged 1 commit intonextauthjs:mainfrom Aug 31, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@rexfordessilfie is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
balazsorban44
approved these changes
Aug 31, 2023
Member
balazsorban44
left a comment
balazsorban44
left a comment
There was a problem hiding this comment.
Thanks! Linting should likely be required on PRs.
Contributor
Author
|
Thank you too @balazsorban44 and @ThangHuuVu! That sounds great, and lint checks would be super! 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This PR fixes the currently failing
auth-docsbuild for repos. The is failing because the regex for grabbing the provider id's is unable to grab the id forazure-devops.tsfile in the azure devops provider.The id is not being grabbed becuase the file is not formatted properly to use double-quotes which the regex requires to work! This fixes the issue by formatting the file.
The regex could also be updated to support single-quotes, or we might add CI to ensure all files are appropriately linted! Leaving this open for discussuion before proceeding with such a fix.
🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: #8464
📌 Resources