chore: simplify vitest config and fix some build issues#1606
Merged
Conversation
Fixed issues: - When building with `dev` we were not enabling vue-devtools. This is fixed by setting `NODE_ENV=development`. - The tsconfig rootdir was not aligned with the `includes` section. All included files need to be within the root dir. So we now have one config for production code and one for setup and tests. - The config option "rollup types" will create independent type, this causes the filepicker module to be incompatible with the index module we exported. Fixed by not rolling up types (note: roll up types only works when there is only a single entry point) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
ShGKme
approved these changes
Feb 28, 2025
Contributor
There was a problem hiding this comment.
I was sure there is a way to set NODE_ENV in Vite via arg... But probably it was only available in Webpack.
Not a fun of having .env.development file just to enable devtools in dev, but it looks like it is the best cross-platform solution if we want to build on Windows as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issues:
devwe were not enabling vue-devtools. This is fixed by settingNODE_ENV=development.includessection. All included files need to be within the root dir. So we now have one config for production code and one for setup and tests.