Conversation
Codecov ReportBase: 97.18% // Head: 98.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 97.18% 98.68% +1.50%
==========================================
Files 4 10 +6
Lines 71 152 +81
Branches 18 37 +19
==========================================
+ Hits 69 150 +81
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cac806a to
a2f62ec
Compare
| */ | ||
| get source(): string { | ||
| // strip any ending slash | ||
| return this._data.source.replace(/\/$/i, '') |
There was a problem hiding this comment.
does this imply that invalid data was passed to data.source?
There was a problem hiding this comment.
No, it's just to help standardizing the source format a tiny bit. Would you prefer a more restrictive approach and throwing?
I wasn't sure about leaving the ending slash or not. :)
a2f62ec to
9968784
Compare
|
attributes would be usable for any webdav attributes not being part of the typed classes I guess? |
Yes, whatever we want that is not some kind of 'official' for a file or folder representation :) |
artonge
left a comment
There was a problem hiding this comment.
Few comments, and as I said, I would go for prefixing the class names, NcFile, NcFolder, ... to prevent confusion with default browser APIs.
9968784 to
b4ae6b1
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
b4ae6b1 to
e025fd7
Compare
Uh oh!
There was an error while loading. Please reload this page.