refactor(NcCheckboxRadioSwitch): Do not use HTML attribute name id as property name
#5516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to next |
Antreesy
approved these changes
Apr 23, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Shouldn't be a breaking change, as it's an internal component, right?
ShGKme
reviewed
Apr 23, 2024
ShGKme
changed the title
id as property nameid as property name
Contributor
Yes, this is an internal component |
susnux
force-pushed
the
fix/checkbox-input-id
branch
from
2453396 to
f7d6847
Compare
…operty name Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/checkbox-input-id
branch
from
f7d6847 to
83c8b38
Compare
ShGKme
approved these changes
Feb 28, 2025
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
I forgot to approve back then 🙈
Merged
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
We tried already in the past to not use native attribute names for custom props to prevent future issues, so lets use a custom name here.
🏁 Checklist
nextrequested with a Vue 3 upgrade