fix(NcEmojiPicker): not focusable when used in another focus trap #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
bug
susnux
reviewed
Feb 28, 2025
susnux
reviewed
Feb 28, 2025
susnux
reviewed
Feb 28, 2025
Comment on lines
+358
to
+362
| created() { | ||
| // Component has its own custom focus management | ||
| // The global focus trap stack should be paused | ||
| useTrapStackControl(() => this.open) | ||
| }, |
Contributor
There was a problem hiding this comment.
Does this work? As it probably needs to be registered in the setup method.
Contributor
Author
There was a problem hiding this comment.
Yes (see screenshots).
It works because lifecycle hooks have the setup context. And a getter is a valid way to provide reactive value.
created works same as setup, but with access to this.
To move it to setup we'd need to move all the reactive variables to setup. I didn't want to change components too much just to use the composable.
susnux
reviewed
Feb 28, 2025
ShGKme
force-pushed
the
fix/NcEmojiPicker--focus-trap-stack
branch
from
cf1b158 to
6476ad7
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/NcEmojiPicker--focus-trap-stack
branch
from
6476ad7 to
d607354
Compare
Contributor
Author
|
Force-pushed SPDX header, no other changes. |
Contributor
Author
|
/backport to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcEmojiPickernow has it's own focus trap implementation => global one must be paused (like inNcActions)NcModalhas similar thing but not the same thing. Not touching nowHow to test:
NcModalexample in vue-styleguidistcontainer=".emoji-modal"🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade