fix(lint-php): only run linter on php file changes#735
fix(lint-php): only run linter on php file changes#735SebastianKrupinski wants to merge 1 commit into
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
So the second checkout for the "changes" step is more expensive then simply running it. Especially when CI is saturated and you need to queue another step after waiting 40 mins to get your run scheduled. |
Hey, The driving force behind this was not execution time, it was waiting time. This workflow passing is a requirement for many of our apps, for a green ci. We schedule 5 unneeded jobs when there are no php changes (one per php version), which we need to wait for because the ubuntu-latest runners are always busy during the day, but the low runners are not. Therefore checking for changes on the low runners and not scheduling jobs on the main runners reduces the workload and we don't need to wait until these jobs are run. For instance, it makes no sense for this workflow to run when you make a single line change to a vue file. |
|
My thought is just the other way around: Since the lint now takes 0 seconds, we could switch that to low. It takes close to no time, and no resources either. Also since your last changes it is only 2 jobs, php min and max. |
Summary