Skip to content

fix(lint-php): only run linter on php file changes#735

Open
SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/lint-php-on-changes
Open

fix(lint-php): only run linter on php file changes#735
SebastianKrupinski wants to merge 1 commit into
masterfrom
fix/lint-php-on-changes

Conversation

@SebastianKrupinski
Copy link
Copy Markdown
Contributor

Summary

  • added logic to check if a php file was changed, to prevent workflow from running when no php changes have been made

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@nickvergessen
Copy link
Copy Markdown
Member

So the second checkout for the "changes" step is more expensive then simply running it. Especially when CI is saturated and you need to queue another step after waiting 40 mins to get your run scheduled.

@SebastianKrupinski
Copy link
Copy Markdown
Contributor Author

SebastianKrupinski commented Jun 6, 2026

So the second checkout for the "changes" step is more expensive then simply running it. Especially when CI is saturated and you need to queue another step after waiting 40 mins to get your run scheduled.

Hey,

The driving force behind this was not execution time, it was waiting time. This workflow passing is a requirement for many of our apps, for a green ci. We schedule 5 unneeded jobs when there are no php changes (one per php version), which we need to wait for because the ubuntu-latest runners are always busy during the day, but the low runners are not. Therefore checking for changes on the low runners and not scheduling jobs on the main runners reduces the workload and we don't need to wait until these jobs are run. For instance, it makes no sense for this workflow to run when you make a single line change to a vue file.

@nickvergessen
Copy link
Copy Markdown
Member

My thought is just the other way around: Since the lint now takes 0 seconds, we could switch that to low. It takes close to no time, and no resources either.

Also since your last changes it is only 2 jobs, php min and max.
Mail still having 5 means it didn't get the "new" workflows yet 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

2 participants