Skip to content

Do not require desugaring #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
p1gp1g wants to merge 2 commits into from
Closed

Do not require desugaring #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a58654b
Do not require desugaring
p1gp1g Nov 11, 2024
081cb00
Add note about desugaring for SDK<24 in README
p1gp1g Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ This library allows you to use accounts as well as the network stack provided by
You can check out the [sample app](https://github.com/nextcloud/Android-SingleSignOn/tree/master/sample) which uses this library to fetch some information via SSO from a Nextcloud instance.
The sample app uses the [Retrofit approach](#51-using-retrofit). Be aware though, that it is for demonstration purposes only. Exception handling, state management etc. must be implemented depending on your use case.

If you need to support __SDK lower than 24__, you must enable [library desugaring](https://developer.android.com/studio/write/java8-support#library-desugaring).

### 1) Add this library to your project

```gradle
Expand Down
3 changes: 0 additions & 3 deletions lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ android {
}

compileOptions {
coreLibraryDesugaringEnabled true
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
Expand Down Expand Up @@ -114,8 +113,6 @@ detekt {
}

dependencies {
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.3'

implementation "androidx.appcompat:appcompat:1.7.0"
implementation 'androidx.annotation:annotation:1.9.1'
implementation 'androidx.core:core:1.13.1'
Expand Down