Skip to content

fix(agent): validate request path before forwarding to ExApp #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
May 14, 2026
Merged

fix(agent): validate request path before forwarding to ExApp #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions haproxy_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
from pydantic import BaseModel, Field, ValidationError, computed_field, model_validator

APPID_PATTERN = re.compile(r"(?:^|/)exapps/([^/]+)")
# Matches `..` path segments in any literal/encoded form: separators can be `/` or %2F,
# the dots themselves can be `.` or %2E (any case combination, e.g. `..`, `%2e.`, `%2E%2e`).
DOT_DOT_SEGMENT_PATTERN = re.compile(r"(?:^|/|%2[fF])(?:\.|%2[eE]){2}(?:/|%2[fF]|$)")
SHARED_KEY = os.environ.get("HP_SHARED_KEY")
NC_INSTANCE_URL = os.environ.get("NC_INSTANCE_URL")
SPOA_ADDRESS = os.environ.get("HP_SPOA_ADDRESS", "127.0.0.1:9600")
Expand Down Expand Up @@ -395,6 +398,11 @@ async def exapps_msg(
LOGGER.warning("IP %s is banned due to excessive failed attempts.", client_ip_str)
return reply.set_txn_var("bad_request", 1)

if DOT_DOT_SEGMENT_PATTERN.search(path):
LOGGER.warning("Rejecting path with parent-directory segment: %s (client_ip=%s)", path, client_ip_str)
await record_failure_unless_trusted(client_ip_str, request_headers)
return reply.set_txn_var("bad_request", 1)

match = APPID_PATTERN.search(path)
if not match:
LOGGER.error("Invalid request path, cannot find AppID: %s", path)
Expand Down
Loading