Public API booking does not trigger manager approval email for non-auto-accept rooms

[vst662-source]

Environment:

• Nextcloud 33.0.3
• RoomVox 1.1.0

Steps to reproduce:

1. Create a room with autoAccept = false and at least one assigned Manager
2. Create a booking via POST /api/v1/rooms/{id}/bookings with an external organizer email
3. Booking is created successfully with status: pending

Expected:
Manager receives the approval-request email (same as when the booking is created via the Nextcloud Calendar app).

Actual:
No email to the manager. The booker does receive a confirmation email after the manager approves, so the SMTP path itself is fine.

Verified:
The same room, same manager, same SMTP config — booked through Nextcloud Calendar — produces the manager approval email correctly. So the issue is specific to the public API booking path bypassing the Sabre iTIP scheduling plugin that emits the approval mail.

Possible cause: POST /api/v1/rooms/{id}/bookings writes directly to the room calendar without going through the iTIP pipeline where the manager-notification hook lives.

---

While looking into this, I found another issue with a similar result in lib/Service/CalDAVService.php (around line 961, inside createBooking()):

if ($organizer !== '') {
    $icsLines[] = 'ORGANIZER;CN=' . $this->escapeIcsText($organizer) . ':mailto:' . $organizer . '@localhost';
}

@localhost is unconditionally appended to $organizer. When the API is called with an external email address as organizer (my use case), this produces mailto:user@company.com@localhost — not a deliverable address. CN is also set to the email itself instead of a display name.

This looks like the same root issue as the missing manager notification: createBooking() writes directly into the room calendar and adds only the room as an ATTENDEE, bypassing the iTIP pipeline where the manager-approval hook lives. The whole API booking path seems to assume $organizer is an internal Nextcloud user ID (where @localhost would be a pseudo-domain suffix, similar to the rb_* service accounts).

[Rikdekker]

Thanks for the very thorough report — both issues you spotted were real, and your hypothesis about the API path bypassing the iTIP pipeline was spot on.

Fixed in v1.1.1 (just released): https://github.com/nextcloud/RoomVox/releases/tag/v1.1.1

What changed:

• POST /api/v1/rooms/{id}/bookings (and the internal POST /api/rooms/{id}/bookings) now trigger the manager approval mail on non-auto-accept rooms — same mail the iTIP/CalDAV path produces, just wired into both controllers directly since they don't traverse the Sabre scheduling plugin.
• The @localhost suffix on ORGANIZER is gone. External email addresses are emitted as-is, NC user IDs are resolved to their canonical email + display name via IUserManager, and unresolvable input causes the property to be omitted entirely rather than fabricated (same approach as the Organizer not mail address when single person book a room #5 fix for the LOCATION-fallback). CN is now a display name, not the raw email.
• Internal cleanup while we were there: MailService migrated off the \OC::$server->get() service-locator anti-pattern in favour of proper constructor injection of IUserManager.

Closing — please reopen if anything still misbehaves after upgrading. Thanks again for the great write-up!