Skip to content

[stable33] Fix npm audit#2508

Merged
artonge merged 2 commits intostable33from
automated/noid/stable33-fix-npm-audit
Apr 14, 2026
Merged

[stable33] Fix npm audit#2508
artonge merged 2 commits intostable33from
automated/noid/stable33-fix-npm-audit

Conversation

@nextcloud-command
Copy link
Copy Markdown
Contributor

@nextcloud-command nextcloud-command commented Apr 12, 2026

● # Audit report

This audit fix resolves 1 of the total 11 vulnerabilities found in your project.

Updated dependencies

Fixed vulnerabilities

vite #

  • Vite Vulnerable to Path Traversal in Optimized Deps .map Handling
  • Severity: moderate
  • Reference: GHSA-4w7w-66w2-5vf9
  • Affected versions: 7.0.0 - 7.3.1
  • Package usage:
    • node_modules/vite

Additional fixes

Fixed 3 more high-severity vulnerabilities by adjusting overrides:

rollup

  • Rollup 4 has Arbitrary File Write via Path Traversal
  • Severity: high
  • Reference: GHSA-mw96-cpmx-2vgc
  • Affected versions: 4.0.0 - 4.58.0
  • Fix: Removed the rollup: "v4.40.1" override that was pinning vite's rollup to a vulnerable version. Vite 7.3.2 already requires rollup ^4.43.0 which is safe.

picomatch

  • Method Injection in POSIX Character Classes causes incorrect Glob Matching
  • Picomatch has a ReDoS vulnerability via extglob quantifiers
  • Severity: high
  • References: GHSA-3v7f-55p6-f55p,
    GHSA-c2c7-rcm5-vvqj
  • Affected versions: <=2.3.1
  • Fix: Added "picomatch@2": "^2.3.2" override to bump transitive dependencies to the fixed version.

Remaining unfixable vulnerabilities (7 low)

elliptic

  • Elliptic Uses a Cryptographic Primitive with a Risky Implementation
  • Severity: low
  • Reference: GHSA-848j-6mx2-7j84
  • Upstream in @nextcloud/vite-configvite-plugin-node-polyfillsnode-stdlib-browsercrypto-browserifyelliptic. No fix available.

Signed-off-by: GitHub <noreply@github.com>
@nextcloud-command nextcloud-command added 3. to review dependencies Pull requests that update a dependency file labels Apr 12, 2026
@cypress
Copy link
Copy Markdown

cypress bot commented Apr 12, 2026

Activity    Run #3576

Run Properties:  status check passed Passed #3576  •  git commit e9a0874eca: [stable33] Fix npm audit
Project Activity
Branch Review automated/noid/stable33-fix-npm-audit
Run status status check passed Passed #3576
Run duration 01m 58s
Commit git commit e9a0874eca: [stable33] Fix npm audit
Committer Nextcloud Command Bot
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

The rollup v4.40.1 override was pinning vite's rollup to a version
in the vulnerable range (4.0.0-4.58.0, GHSA-mw96-cpmx-2vgc).
Vite 7.3.2 already requires rollup ^4.43.0 which is safe.

Added picomatch@2 override to ^2.3.2 to fix GHSA-3v7f-55p6-f55p
and GHSA-c2c7-rcm5-vvqj (method injection and ReDoS).

Remaining 7 low-severity elliptic advisories are upstream in
@nextcloud/vite-config via vite-plugin-node-polyfills and cannot
be fixed from this project.

AI-Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala requested review from artonge and susnux April 13, 2026 20:33
@miaulalala miaulalala self-assigned this Apr 13, 2026
@artonge artonge merged commit 3589929 into stable33 Apr 14, 2026
53 checks passed
@artonge artonge deleted the automated/noid/stable33-fix-npm-audit branch April 14, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants