fix(cypress): exclude screenshot spec from regular PR CI runs#2552
Merged
miaulalala merged 1 commit intomasterfrom May 4, 2026
Merged
fix(cypress): exclude screenshot spec from regular PR CI runs#2552miaulalala merged 1 commit intomasterfrom
miaulalala merged 1 commit intomasterfrom
Conversation
The screenshots.cy.ts spec is intended for the manual screenshots.yml workflow only. Including it in the default e2e spec pattern caused it to run on every PR, where the reduced app setup (viewer only) triggered a JS crash before any test could start. excludeSpecPattern is ignored when a spec is passed explicitly, so the screenshots.yml workflow is unaffected. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Activity
 |
||||||||||||||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
fix/exclude-screenshots-from-pr-ci
|
| Run status |
|
| Run duration | 01m 14s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
2
|
 |
0
|
 |
0
|
 |
8
|
 |
0
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has creation activity |
Test Replay
Screenshots
|
|
| Test | Artifacts | |
|---|---|---|
| Check that user's settings survive a reload > Form survive a reload |
Test Replay
Screenshots
|
|
nickvergessen
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screenshots.cy.ts spec is intended for the manual screenshots.yml workflow only. Including it in the default e2e spec pattern caused it to run on every PR, where the reduced app setup (viewer only) triggered a JS crash before any test could start.
excludeSpecPattern is ignored when a spec is passed explicitly, so the screenshots.yml workflow is unaffected.
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com